[wp-trac] [WordPress Trac] #52009: Some core blocks are positioned incorrectly in some core bundled themes

[WordPress Trac]

#52009: Some core blocks are positioned incorrectly in some core bundled themes
-----------------------------------------+---------------------
 Reporter:  talldanwp                    |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  5.6.1
Component:  Bundled Theme                |     Version:  5.5.3
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch needs-screenshots  |     Focuses:
-----------------------------------------+---------------------

Comment (by poena):

 == Twenty Fourteen
 The patch works well.

 As with the other themes (sorry, this is becoming repetitive),
 the code block has a background color and padding in the editor, but not
 on the front.
 The editor style for this is not being applied because the specificity is
 too low, it is being overwritten by the .editor-styles-wrapper pre style.
 Adding a new selector with .editor-styles-wrapper before .wp-block-code
 would solve this.
 See these lines:
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyfourteen/css/editor-blocks.css#L151
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyfourteen/css/editor-blocks.css#L355



 == Twenty Fifteen
 The removal of the max width for the pre tag works well.

 I did not understand the purpose of the margin change in
 twentyfifteen/css/blocks.css.
 With the style change applied, the qoute block is moved to the left,
 outside the rest of the content,
 and only if the block is aligned to the left (the default).

 I made a typo for the image description :) :
 ''The adjusted margin moves the quote to the left of the rest of the
 content (front view)''

 I don't think the margin for the .rtl blockquote should be removed,
 because it wont match the ltr blockquote from line
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyfifteen/css/editor-style.css#L111

 Styles for the blockquote element are kept for backwards compatibility
 for posts created before the block editor, but also for quotes in for
 example the HTML block.

 The code block has a background color and padding in the editor, but not
 on the front.
 The editor style for this is not being applied because the specificity is
 too low, it is being overwritten by the .editor-styles-wrapper pre style.
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyfifteen/css/editor-blocks.css#L638
 Adding a new selector with .editor-styles-wrapper before .wp-block-code
 would solve this.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52009#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform