[wp-trac] [WordPress Trac] #51956: Fatal error with PHP8 in header link RSS feed on dashboard widget

WordPress Trac noreply at wordpress.org
Wed Dec 16 00:49:47 UTC 2020


#51956: Fatal error with PHP8 in header link RSS feed on dashboard widget
----------------------------+------------------------
 Reporter:  NicolasKulka    |       Owner:  (none)
     Type:  defect (bug)    |      Status:  closed
 Priority:  high            |   Milestone:
Component:  Widgets         |     Version:
 Severity:  critical        |  Resolution:  duplicate
 Keywords:  php8 has-patch  |     Focuses:  rest-api
----------------------------+------------------------

Comment (by iandunn):

 In [changeset:"49803" 49803]:
 {{{
 #!CommitTicketReference repository="" revision="49803"
 Feed: Merge multiple header values to avoid fatal error.

 When SimplePie parses HTTP headers, it combines multiple values for the
 same header into a comma-separated string. `WP_SimplePie_File` overrides
 the parsing, but was leaving them as an array instead.

 That lead to a fatal error in PHP 8, because other parts of the codebase
 ended up passing an array to a function that expected a string.

 Props david.binda, litemotiv, inc2734, NicolasKulka, hellofromTonya,
 mbabker, skithund, SergeyBiryukov, desrosj, timothyblynjacobs.
 Fixes #51056. See #51956.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51956#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list