[wp-trac] [WordPress Trac] #47778: Unexpected unknown propertys in wp-includes/js/crop/cropper.css

WordPress Trac noreply at wordpress.org
Wed Dec 9 01:17:10 UTC 2020


#47778: Unexpected unknown propertys in wp-includes/js/crop/cropper.css
--------------------------+----------------------
 Reporter:  ozmatflc      |       Owner:  (none)
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  Customize     |     Version:  5.2.2
 Severity:  normal        |  Resolution:  wontfix
 Keywords:                |     Focuses:
--------------------------+----------------------

Comment (by SIRavecavec):

 Replying to [comment:3 SergeyBiryukov]:
 > Hi @ozmatflc, welcome to WordPress Trac! Thanks for the ticket.
 >
 > Introduced in [4629], replaced with Jcrop in [10846], replaced with
 imgAreaSelect in [14907].
 >
 > Yes, this appears to be a "CSS hack" for IE 5. While that browser is
 [https://make.wordpress.org/core/handbook/best-practices/browser-support/
 no longer supported], these older libraries are only kept for backward
 compatibility, I don't see a benefit in editing them.

 The benefits to edit and fix them, is code quality, passing security
 validation and internal audits!

 I am still not sure why the OLD mentality if its not bothering me and is
 not burning, let it be.

 Its easy to say wont be taken out for backward compatibilty, so lets start
 building software backwards not forward moving.

 I was just about to open a ticket while this came out with many other on a
 sonarqube test done recently.

 No matter what hack that is for what purpose, first of all has no meaning
 at all to keep it, second of all it invalidates a file that has entire
 rest of code clean up to that point.

 So again what is with this approach that keeps core code bloated with
 errors same with jQuery and many other sides that have known
 vulnerabilities for years now and if a few of them arent properly
 exploited, let's not move on to fix them.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47778#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list