[wp-trac] [WordPress Trac] #51965: About Page: Full stop is added in wrong place
WordPress Trac
noreply at wordpress.org
Tue Dec 8 11:26:03 UTC 2020
#51965: About Page: Full stop is added in wrong place
--------------------------+------------------------------
Reporter: mukesh27 | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Help/About | Version: 5.6
Severity: normal | Resolution:
Keywords: has-patch | Focuses: administration
--------------------------+------------------------------
Comment (by SergeyBiryukov):
Thanks for the ticket! This was previously reported in #51813.
As noted in comment:8:ticket:51813, "WordPress 5.6 Field Guide." is a
complete sentence, so I think the full stop is in the correct place here.
This is consistent with some other strings in core, for example:
* [source:branches/5.6/src/wp-admin/update-core.php?marks=1011#L1008
"Check again" link] on WordPress Updates screen:
{{{
<a href="' ... '">' . __( 'Check again.' ) . '</a>'
}}}
* [source:branches/5.6/src/wp-admin/includes/class-wp-plugins-list-
table.php?marks=414#L400 "Search for plugins" link] on the Plugins screen:
{{{
<a href=" ... '">' . __( 'Search for plugins in the WordPress Plugin
Directory.' ) . '</a>'
}}}
A similar conversation was also
[https://wordpress.slack.com/archives/C02RQBWTW/p1605230518264800 on Slack
after 5.6 beta 4]:
yui 04:21
`<a href="%s">Switch to automatic updates for maintenance and security
releases only.</a>`
is it really meant to have dot before `</a>`?
helen 04:25
It’s the entire line, so yes.
That said, this appears to be not a hard and fast rule, there are some
other arguments and considerations:
https://ux.stackexchange.com/questions/17331/should-a-full-sentence-html-
link-include-the-period-in-the-linked-text
Ideally, we'd like to be consistent with this in core.
Marking this with the `ui-copy` keyword for a native English speaker to
chime in :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51965#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list