[wp-trac] [WordPress Trac] #51937: Fatal error while cropping

[WordPress Trac]

#51937: Fatal error while cropping
---------------------------------+-----------------------------------------
 Reporter:  Boniu91              |       Owner:  iandunn
     Type:  defect (bug)         |      Status:  accepted
 Priority:  high                 |   Milestone:  5.6
Component:  Customize            |     Version:  5.6
 Severity:  blocker              |  Resolution:
 Keywords:  php8 https needs-    |     Focuses:  javascript, administration
  patch                          |
---------------------------------+-----------------------------------------
Changes (by iandunn):

 * status:  new => accepted
 * focuses:  administration => javascript, administration
 * severity:  normal => blocker
 * priority:  normal => high
 * owner:  (none) => iandunn
 * milestone:  Awaiting Review => 5.6
 * keywords:  reporter-feedback => php8 https needs-patch


Comment:

 Ah, thanks!

 Some rough thoughts:

 1. '''PHP:''' Add some code to detect bad inputs and handle it gracefully,
 similar to r49019
 ([https://wordpress.slack.com/archives/C02RQBWTW/p1607095114432200?thread_ts=1607093264.429200&cid=C02RQBWTW
 h/t] @SergeyBiryukov). This is maybe a blocker for 5.6? I'll start looking
 into this.

 1. '''JS:''' Detect the bad inputs, disable the `crop` button, and show a
 user-friendly error. This would be `normal` priority / `future release`.

 1. '''HTTPS UX:''' Show an admin notice on `Admin > Settings > General`
 when the mixed content is detected, encouraging the admin to upgrade to
 HTTPS-only. This could also be `normal` / `future`. There may already be a
 ticket for this, as part of the HTTPS project?

 Any thoughts on that approach?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51937#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform