[wp-trac] [WordPress Trac] #51928: Provide plugin/theme update failure data to dot org

[WordPress Trac]

#51928: Provide plugin/theme update failure data to dot org
-------------------------------------------------+-------------------------
 Reporter:  afragen                              |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback needs-unit-   |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by dd32):

 Looking at [attachment:"51928.3.diff"]:
 > `'fs_method_direct' => ! empty( $GLOBALS['_wp_filesystem_direct_method']
 ) ? $GLOB['_wp_filesystem_direct_method'] : ''`
 `$GLOB` variable truncated.

 > `'wp_error'         => $result,`
 I'm not sure how `WP_Error` will JSON serialize here, it might be better
 to simply add the `error_code` and `error_data` instead. It'd also be
 worthwhile checking what `error_data` actually holds in these cases, as
 for core we specifically "anonymised" it by removing ABSPATH from the
 data: https://core.trac.wordpress.org/browser/tags/5.5.1/src/wp-
 admin/includes/update-core.php?marks=1106#L1103

 I can make the WordPress.org APIs store/process/etc the data that gets
 sent from this in whatever format is decided, it's just easier to be able
 to do less processing as it makes aggregating the data far simpler.

 Another data point that might make sense adding here, is whether it was an
 auto-update or manually triggered update. It'll allow the resulting
 aggregated data to focus on failures that happen via autoupdates, to add
 protections to avoid autoupdates when that scenario is detected.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51928#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform