[wp-trac] [WordPress Trac] #51918: I18n - Application Passwords table dates

WordPress Trac noreply at wordpress.org
Thu Dec 3 21:08:04 UTC 2020


#51918: I18n - Application Passwords table dates
-----------------------------------+--------------------------------
 Reporter:  pedromendonca          |       Owner:  TimothyBlynJacobs
     Type:  defect (bug)           |      Status:  closed
 Priority:  normal                 |   Milestone:  5.6
Component:  Application Passwords  |     Version:  5.6
 Severity:  normal                 |  Resolution:  fixed
 Keywords:  has-patch              |     Focuses:
-----------------------------------+--------------------------------
Changes (by SergeyBiryukov):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"49747" 49747]:
 {{{
 #!CommitTicketReference repository="" revision="49747"
 App Passwords: Ensure the Created At and Last Used dates are properly
 translated.

 The `date_i18n` function is now used when formatting the dates in PHP
 instead of `gmdate` which doesn't handle localization properly.

 Additionally, we now use a translation to get the date format to use
 instead of pulling from the `date_format` option which is only supposed to
 affect the front-end.

 Lastly, when passing the date format to the Backbone JS template, we now
 use `wp_json_encode()` to format the value for JavaScript. This ensures
 that backslashes are properly preserved which are used by some locales to
 escape date formatting control characters.

 Props pedromendonca, TimothyBlynJacobs, ocean90, hellofromtonya,
 SergeyBiryukov, antpb.
 Reviewed by TimothyBlynJacobs, SergeyBiryukov.
 Merges [49746] to the 5.6 branch.
 Fixes #51918.
 See [35811].
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51918#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list