[wp-trac] [WordPress Trac] #51913: Potential `unsupported operand types` dashboard fatal on PHP8 + multisite + upload space check

[WordPress Trac]

#51913: Potential `unsupported operand types` dashboard fatal on PHP8 + multisite +
upload space check
--------------------------------+----------------------------------------
 Reporter:  iandunn             |       Owner:  iandunn
     Type:  defect (bug)        |      Status:  accepted
 Priority:  highest omg bbq     |   Milestone:  5.6
Component:  Administration      |     Version:
 Severity:  blocker             |  Resolution:
 Keywords:  php8 needs-testing  |     Focuses:  administration, multisite
--------------------------------+----------------------------------------

Comment (by iandunn):

 In the public plugin repo, there are some plugins accessing the transient
 directly:

 https://wpdirectory.net/search/01ERHZ02VEQ161CMAR4JHVZXCQ

 ...but most are just deleting it.

 These 3 seem to have copied older versions of `get_dirsize()` and
 `recurse_dirsize()` into their codebase directly:

 * PT Addons for Elementor Lite - 4k installs
 * MediaPress - 3k installs
 * Trustalyze Verified WooCommerce Reviews Extension - 10 installs

 It looks like they could set the transient w/ the old structure, and then
 that'd cause a fatal when Core tries to access it.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51913#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform