[wp-trac] [WordPress Trac] #51123: commonL10n and other JS globals removed without backwards compatibility

WordPress Trac noreply at wordpress.org
Mon Aug 31 18:10:12 UTC 2020


#51123: commonL10n and other JS globals removed without backwards compatibility
---------------------------------------------+-------------------------
 Reporter:  kbjohnson90                      |       Owner:  ocean90
     Type:  defect (bug)                     |      Status:  reviewing
 Priority:  normal                           |   Milestone:  5.5.1
Component:  Script Loader                    |     Version:  5.5
 Severity:  normal                           |  Resolution:
 Keywords:  needs-dev-note has-patch commit  |     Focuses:  javascript
---------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * keywords:  needs-dev-note has-patch => needs-dev-note has-patch commit


Comment:

 [attachment:"51123.3.diff"] addresses a few points from comment:32 and
 comment:34:

 * Switch `console.error()` to `console.warn()`.
 * Rename duplicate `window.tagsl10n` object to `window.tagsSuggestL10n`.
 * Add missing `wpWidgets.l10n` object.

 I think this is ready for commit now.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51123#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list