[wp-trac] [WordPress Trac] #51184: get_the_date() checks $format only for empty variable and fails on false boolean - since WP 5.5

WordPress Trac noreply at wordpress.org
Mon Aug 31 16:12:33 UTC 2020


#51184: get_the_date() checks $format only for empty variable and fails on false
boolean - since WP 5.5
-------------------------------------+-------------------------------------
 Reporter:  wittich                  |       Owner:  SergeyBiryukov
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  5.5.1
Component:  Date/Time                |     Version:  5.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-unit-      |     Focuses:  template, coding-
  tests commit dev-feedback fixed-   |  standards
  major                              |
-------------------------------------+-------------------------------------

Comment (by Rarst):

 @SergeyBiryukov note that your implementation changes return filter
 behavior (PR as worked out doesn't). Now filters would receive a default
 format instead of original format if it's empty. Feels close to BC break
 for me.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51184#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list