[wp-trac] [WordPress Trac] #51184: get_the_date() checks $format only for empty variable and fails on false boolean - since WP 5.5

WordPress Trac noreply at wordpress.org
Sat Aug 29 19:05:48 UTC 2020


#51184: get_the_date() checks $format only for empty variable and fails on false
boolean - since WP 5.5
-------------------------------------+-------------------------------------
 Reporter:  wittich                  |       Owner:  SergeyBiryukov
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  5.5.1
Component:  Date/Time                |     Version:  5.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  template, coding-
  has-unit-tests                     |  standards
-------------------------------------+-------------------------------------

Comment (by wittich):

 I updated my pull request https://github.com/WordPress/wordpress-
 develop/pull/505

 Don't know what @akabarikalpesh did different?!

 @Rarst The test runs though with docker and `npm run test:php`, see here
 for the results of the test: https://github.com/WordPress/wordpress-
 develop/runs/1045820515

 Hope that's it for #51184 was a fun experience to contribute.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51184#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list