[wp-trac] [WordPress Trac] #51184: get_the_date() checks $format only for empty variable and fails on false boolean - since WP 5.5

[WordPress Trac]

#51184: get_the_date() checks $format only for empty variable and fails on false
boolean - since WP 5.5
-------------------------------------+-------------------------------------
 Reporter:  wittich                  |       Owner:  SergeyBiryukov
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  5.5.1
Component:  Date/Time                |     Version:  5.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  template, coding-
  has-unit-tests                     |  standards
-------------------------------------+-------------------------------------
Changes (by Rarst):

 * keywords:  needs-unit-tests has-patch needs-testing => has-patch needs-
     testing has-unit-tests


Comment:

 For suggested condition the statements need to be reversed (since check is
 now for validity, not for invalidity). Pull request above already does
 that and has unit tests (I hadn't run them though, just looked at the
 code).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51184#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform