[wp-trac] [WordPress Trac] #51184: get_the_date() checks $format only for empty variable and fails on false boolean - since WP 5.5

[WordPress Trac]

#51184: get_the_date() checks $format only for empty variable and fails on false
boolean - since WP 5.5
------------------------------------------+-----------------------------
 Reporter:  wittich                       |       Owner:  SergeyBiryukov
     Type:  defect (bug)                  |      Status:  reopened
 Priority:  normal                        |   Milestone:  5.5.1
Component:  Date/Time                     |     Version:  5.5
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |     Focuses:
------------------------------------------+-----------------------------

Comment (by wittich):

 I update my pull request https://github.com/WordPress/wordpress-
 develop/pull/505 don't know if that was to correct way. It's commit
 217ca22.

 I found now the logic better to read:

 {{{#!php
     if ( is_string( $format ) && '' !== $format ) {
         // use $format
     } else {
         // use default
     }
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51184#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform