[wp-trac] [WordPress Trac] #51014: Improve the structure format on the class-wp-media-list-table file
WordPress Trac
noreply at wordpress.org
Fri Aug 28 09:58:46 UTC 2020
#51014: Improve the structure format on the class-wp-media-list-table file
--------------------------------------+-------------------------------
Reporter: Laxman Prajapati | Owner: SergeyBiryukov
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.6
Component: Administration | Version: trunk
Severity: normal | Resolution:
Keywords: good-first-bug has-patch | Focuses: coding-standards
--------------------------------------+-------------------------------
Comment (by hansjovisyoast):
I notices a few code standard issues in the patch, which I addressed in
`51014-2.patch`:
* The `if` statement on lines 272 to 276 was not correctly indented. It
had one tab too many.
* Line 425 had a trailing whitespace.
There is one code standard issue left about a strict comparison:
{{{
FILE: src/wp-admin/includes/class-wp-media-list-table.php
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
656 | WARNING | Found: ==. Use strict comparisons (=== or !==).
| | (WordPress.PHP.StrictComparisons.LooseComparison)
-------------------------------------------------------------------------------------------------------------------
}}}
Since this is a pre-existing issue, where fixing it could change the
behavior, I decided to leave it as is.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51014#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list