[wp-trac] [WordPress Trac] #50999: Scripts loaded through concatenation don't print their translations.

[WordPress Trac]

#50999: Scripts loaded through concatenation don't print their translations.
-------------------------------------+-------------------------------------
 Reporter:  herregroen               |       Owner:  ocean90
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  high                     |   Milestone:  5.5.1
Component:  I18N                     |     Version:  5.5
 Severity:  major                    |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  accessibility,
  needs-unit-tests                   |  javascript
-------------------------------------+-------------------------------------

Comment (by ocean90):

 Replying to [comment:23 johnbillion]:
 > Can someone provide steps to reliably reproduce? Maybe @herregroen ?
 Cheers!


 * Run `LOCAL_DIR=build npm run env:start`
 * Run `npm run grunt`
 * Make sure `SCRIPT_DEBUG` is set to false in wp-config.php
 * Download and activate https://downloads.wordpress.org/plugin/wordpress-
 seo.14.8.zip
 * Go to http://localhost:8889/wp-admin/options-general.php and select
 Deutsch/German as site language
 * Go to http://localhost:8889/wp-admin/site-health.php
 * Notice that the subtitle changes from "Die Ergebnisse werden noch
 geladen…" to "Should be improved". Correct would be the existing
 translation "Sollte verbessert werden".

 Inspecting the source I see [ https://cloudup.com/cdPsn0rddeV this]
 without the plugin and [https://cloudup.com/cOFeh2DOov3 this] with the
 plugin activated.

 [attachment:"50999.diff"] doesn't work for me, it seems to print raw JS on
 the page due to missing `<script>` tags. [attachment:"translations-no-
 concat.patch"] looks better.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50999#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform