[wp-trac] [WordPress Trac] #51154: sitemaps should be initialized before each test is run

WordPress Trac noreply at wordpress.org
Thu Aug 27 04:19:57 UTC 2020


#51154: sitemaps should be initialized before each test is run
------------------------------+---------------------
 Reporter:  pbiron            |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  5.5.2
Component:  Build/Test Tools  |     Version:  5.5
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+---------------------
Changes (by pbiron):

 * keywords:   => has-patch


Comment:

 Not sure why, but the PR isn't showing up in the "Pull Requests" box
 above.  For reference, it is https://github.com/WordPress/wordpress-
 develop/pull/502.

 And as I expected, `testPublicQueryVarsAreAsExpected()` failed
 `$wp_sitemaps` was nulled...as it should have.  And then when that test
 was updated to include the sitemaps-related public query vars, it then
 succeeds again.

 [attachment:"51154.diff"] contains both of those changes.

 @peterwilsoncc thought maybe this could land in 5.5.1.  But I think
 @SergeyBiryukov is right to delay it to 5.5.2...just to allow a little
 more time to investigate that:

 1. that really was the only problem
 2. that where the patch nulls the `$wp_sitemaps` global is right place
 that that should be done

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51154#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list