[wp-trac] [WordPress Trac] #51123: commonL10n removed without backwards compatibility

WordPress Trac noreply at wordpress.org
Thu Aug 27 02:32:33 UTC 2020


#51123: commonL10n removed without backwards compatibility
---------------------------+-----------------------------
 Reporter:  kbjohnson90    |       Owner:  SergeyBiryukov
     Type:  defect (bug)   |      Status:  reviewing
 Priority:  normal         |   Milestone:  5.5.1
Component:  Script Loader  |     Version:  5.5
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  javascript
---------------------------+-----------------------------

Comment (by TimothyBlynJacobs):

 > defineProperty is unavailable in IE11, whereas __defineGetter__ is.

 @peterwilsoncc is it a particular part of `defineProperty` that isn't
 available? According to MDN it's available, https://developer.mozilla.org
 /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty.

 > Reviewing other deprecated JavaScript code, the functionality is
 generally labelled as such in the docblocks but there isn't an equivalent
 of PHP's _doing_it_wrong() for JavaScript.

 It isn't a `_doing_it_wrong`, but we could potentially use the
 `deprecated` package:
 https://github.com/WordPress/gutenberg/tree/7fef85b97c13ab59b47d6d6299e2ba94e9fb00b5/packages/deprecated

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51123#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list