[wp-trac] [WordPress Trac] #50593: Check requirements when uploading a plugin/theme by ZIP

[WordPress Trac]

#50593: Check requirements when uploading a plugin/theme by ZIP
-----------------------------+-----------------------------
 Reporter:  mariovalney      |       Owner:  SergeyBiryukov
     Type:  defect (bug)     |      Status:  closed
 Priority:  normal           |   Milestone:  5.5
Component:  Upgrade/Install  |     Version:  5.4.2
 Severity:  normal           |  Resolution:  fixed
 Keywords:  has-patch        |     Focuses:  docs
-----------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch commit => has-patch
 * status:  reviewing => closed
 * resolution:   => fixed
 * milestone:  5.5.1 => 5.5


Comment:

 [attachment:"48666.diff"] doesn't seem to work as expected in my testing:

 * `WP_Upgrader_Skin:error()` runs the message through `esc_html(
 strip_tags( ... ) )`, so any links are stripped. That was likely added for
 a reason, so I'm not very comfortable with changing that in a minor
 release.
 * I think the message should use the checks and functions used for similar
 messages elsewhere: `current_user_can( 'update_php' )`,
 `wp_get_update_php_url()`, `wp_get_update_php_annotation()`.

 Going to re-close this as fixed in 5.5. Created #51152 for addressing the
 remaining bits.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50593#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform