[wp-trac] [WordPress Trac] #51011: Empty string comparison on home option during DB upgrades is invalid

[WordPress Trac]

#51011: Empty string comparison on home option during DB upgrades is invalid
-----------------------------+-----------------------------
 Reporter:  fjarrett         |       Owner:  SergeyBiryukov
     Type:  defect (bug)     |      Status:  closed
 Priority:  normal           |   Milestone:  5.5.1
Component:  Upgrade/Install  |     Version:  5.5
 Severity:  minor            |  Resolution:  fixed
 Keywords:                   |     Focuses:
-----------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"48868" 48868]:
 {{{
 #!CommitTicketReference repository="" revision="48868"
 Upgrade/Install: Make the check for empty `home` option in
 `__get_option()` more resilient.

 This addresses a regression in [47808], where the `home` check expected an
 empty string to use `siteurl` as a fallback, but `wpdb::get_var()` returns
 `null` if the option is empty.

 Props fjarrett.
 Fixes #51011.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51011#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform