[wp-trac] [WordPress Trac] #50910: 5.5 Sitemap URLs are incorrectly paginated

[WordPress Trac]

#50910: 5.5 Sitemap URLs are incorrectly paginated
-------------------------------------------------+-------------------------
 Reporter:  jonathanstegall                      |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.5.1
Component:  Sitemaps                             |     Version:  5.5
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by pbiron):

 I investigated the suggestion in
 [https://core.trac.wordpress.org/ticket/50910#comment:15 comment 15], but
 decided against making that change, at least for now, for a few reasons:

 1. that change is not needed the fix ''this'' problem
 2. the way the unit tests are now structured, that change isn't need when
 running the unit tests

 It ''might'' be a worthwhile change to make on it's own, but I'll open
 another ticket where the pros/cons can be discussed.

 While investigating that, however, I came across something odd.  There is
 an existing unit test that fails for me locally and as far as I can tell,
 should be failing on Travis since sitemaps were merged into core.

 It's the test in `tests/phpunit/tests/query/vars.php`, which was added in
 [36045] and changed in [36048].  That test can be run with:

 `phpunit --group 35115`

 It checks that `$wp->public_query_vars` is correct.  But since sitemaps
 were merged into core, that "expected" array should contains `sitemap`,
 `sitemap-subtype`, `sitemap-stylesheet` which it doesn't and the test
 fails for me locally.

 When the tests are run on travis, how has it been passing?  Any ideas
 @SergeyBiryukov ?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50910#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform