[wp-trac] [WordPress Trac] #51129: Avoid the Enable/Disable auto-updates links to appear for externally hosted themes on the Network Admin > Themes screen
WordPress Trac
noreply at wordpress.org
Mon Aug 24 23:06:58 UTC 2020
#51129: Avoid the Enable/Disable auto-updates links to appear for externally hosted
themes on the Network Admin > Themes screen
-----------------------------+-------------------------
Reporter: audrasjb | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.5.1
Component: Upgrade/Install | Version:
Severity: normal | Keywords: needs-patch
Focuses: multisite |
-----------------------------+-------------------------
This is a follow-up to #
As noted by @pbiron in comment number 66:
----
The above (Note: see [48688]) commit did not include the requisite changes
to `WP_MS_Themes_List_Table`. The impact is that in multisite, the
`Enable/Disable auto-updates` links will still appear for externally
hosted themes on the `Network Admin > Themes` screen.
I'm looking into what it will take to add the multisite support for this.
It's complicated by the fact that plugins use an array (returned by
`get_plugin_data()`) and thus can use `array_merge()` on the info in the
transient, `array( 'update-supported => true )` and the plugin_data;
whereas themes use an instance of `WP_Theme`...making the array merge not
possible.
I think something can be worked out using the magic `__get()` and
`__set()` methods of `WP_Theme`...but still looking into that.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51129>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list