[wp-trac] [WordPress Trac] #49413: wp_exif_date2ts should use Dateatime and accept an optional offset
WordPress Trac
noreply at wordpress.org
Sun Aug 23 19:03:28 UTC 2020
#49413: wp_exif_date2ts should use Dateatime and accept an optional offset
--------------------------+------------------------
Reporter: dshanske | Owner: Rarst
Type: defect (bug) | Status: reviewing
Priority: low | Milestone: 5.6
Component: Date/Time | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
--------------------------+------------------------
Comment (by dshanske):
Replying to [comment:16 Rarst]:
> Thank you for keeping this going! :) From quick look at PR it looks
generally sound, but I definitely need to find time to thoroughly read up
on context and review it then.
>
> Accommodating for different versions of input has me suspicious how many
problems/edge cases will float up. Also unit tests (I can take care of
that).
That's why I pulled back from other ideas...I want this to just an
iteration of what is there now...Even if you get rid of the offset check
in the exif function...you still will make the timestamp more accurate by
assuming it is the site timezone.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/49413#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list