[wp-trac] [WordPress Trac] #50664: Theme test failures on Windows

[WordPress Trac]

#50664: Theme test failures on Windows
----------------------------+------------------------------
 Reporter:  SergeyBiryukov  |       Owner:  (none)
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Themes          |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+------------------------------

Old description:

> Background: #39975, #40856.
>
> As previously mentioned in comment:4:ticket:39975 and recently confirmed
> by @davidbaumwald, [48463] uncovered some theme file test failures that
> were previously skipped:
> {{{
> 1) Tests_WP_Customize_Manager::test_import_theme_starter_content
> Expected reuse of non-auto-draft attachment.
> Failed asserting that an array contains 949.
>
> S:\home\wordpress.test\develop\tests\phpunit\tests\customize\manager.php:691
>
> 2) Test_Theme_File::test_theme_file_uri_returns_valid_uri with data set
> #0 ('parent-only.php', 'theme-file-parent', array('theme-file-parent'))
> Failed asserting that two strings are identical.
> --- Expected
> +++ Actual
> @@ @@
> -''
> +'S:\home\wordpress.test\develop\tests\phpunit\includes/../data/themedir1/default
> /parent-only.php'
>
> S:\home\wordpress.test\develop\tests\phpunit\tests\link\themeFile.php:136
>
> 3) Test_Theme_File::test_theme_file_uri_returns_valid_uri with data set
> #1 ('child-only.php', 'theme-file-child', array('theme-file-child'))
> Failed asserting that two strings are identical.
> --- Expected
> +++ Actual
> @@ @@
> -''
> +'S:\home\wordpress.test\develop\tests\phpunit\includes/../data/themedir1/default
> /child-only.php'
>
> S:\home\wordpress.test\develop\tests\phpunit\tests\link\themeFile.php:136
>
> 4) Test_Theme_File::test_theme_file_uri_returns_valid_uri with data set
> #2 ('parent-and-child.php', 'theme-file-child', array('theme-file-
> parent', 'theme-file-child'))
> Failed asserting that two strings are identical.
> --- Expected
> +++ Actual
> @@ @@
> -''
> +'S:\home\wordpress.test\develop\tests\phpunit\includes/../data/themedir1/default
> /parent-and-child.php'
>
> S:\home\wordpress.test\develop\tests\phpunit\tests\link\themeFile.php:136
>
> 5) Test_Theme_File::test_theme_file_uri_returns_valid_uri with data set
> #3 ('neither.php', 'theme-file-parent', array())
> Failed asserting that two strings are identical.
> --- Expected
> +++ Actual
> @@ @@
> -''
> +'S:\home\wordpress.test\develop\tests\phpunit\includes/../data/themedir1/default/neither.php'
>
> S:\home\wordpress.test\develop\tests\phpunit\tests\link\themeFile.php:136
> }}}
>
> It's not quite clear yet whether it's an issue with the tests or with the
> functions being tested.

New description:

 Background: #39975, #40856.

 As previously mentioned in comment:4:ticket:39975 and recently confirmed
 by @davidbaumwald, [48463] uncovered some theme file test failures that
 were previously skipped:
 {{{
 There were 5 failures:

 1) Tests_WP_Customize_Manager::test_import_theme_starter_content
 Expected reuse of non-auto-draft attachment.
 Failed asserting that an array contains 949.

 S:\home\wordpress.test\develop\tests\phpunit\tests\customize\manager.php:691

 2) Test_Theme_File::test_theme_file_uri_returns_valid_uri with data set #0
 ('parent-only.php', 'theme-file-parent', array('theme-file-parent'))
 Failed asserting that two strings are identical.
 --- Expected
 +++ Actual
 @@ @@
 -''
 +'S:\home\wordpress.test\develop\tests\phpunit\includes/../data/themedir1/default
 /parent-only.php'

 S:\home\wordpress.test\develop\tests\phpunit\tests\link\themeFile.php:136

 3) Test_Theme_File::test_theme_file_uri_returns_valid_uri with data set #1
 ('child-only.php', 'theme-file-child', array('theme-file-child'))
 Failed asserting that two strings are identical.
 --- Expected
 +++ Actual
 @@ @@
 -''
 +'S:\home\wordpress.test\develop\tests\phpunit\includes/../data/themedir1/default
 /child-only.php'

 S:\home\wordpress.test\develop\tests\phpunit\tests\link\themeFile.php:136

 4) Test_Theme_File::test_theme_file_uri_returns_valid_uri with data set #2
 ('parent-and-child.php', 'theme-file-child', array('theme-file-parent',
 'theme-file-child'))
 Failed asserting that two strings are identical.
 --- Expected
 +++ Actual
 @@ @@
 -''
 +'S:\home\wordpress.test\develop\tests\phpunit\includes/../data/themedir1/default
 /parent-and-child.php'

 S:\home\wordpress.test\develop\tests\phpunit\tests\link\themeFile.php:136

 5) Test_Theme_File::test_theme_file_uri_returns_valid_uri with data set #3
 ('neither.php', 'theme-file-parent', array())
 Failed asserting that two strings are identical.
 --- Expected
 +++ Actual
 @@ @@
 -''
 +'S:\home\wordpress.test\develop\tests\phpunit\includes/../data/themedir1/default/neither.php'

 S:\home\wordpress.test\develop\tests\phpunit\tests\link\themeFile.php:136
 }}}

 It's not quite clear yet whether it's an issue with the tests or with the
 functions being tested.

--

Comment (by SergeyBiryukov):

 Related: #51111

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50664#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform