[wp-trac] [WordPress Trac] #50999: Scripts loaded through concatenation don't print their translations.
WordPress Trac
noreply at wordpress.org
Thu Aug 20 05:23:50 UTC 2020
#50999: Scripts loaded through concatenation don't print their translations.
--------------------------+-----------------------------
Reporter: herregroen | Owner: SergeyBiryukov
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.5.1
Component: I18N | Version: 5.5
Severity: normal | Resolution:
Keywords: | Focuses: javascript
--------------------------+-----------------------------
Comment (by sageshilling):
Replying to [comment:3 mikeyarce]:
> Thanks for the report @herregroen !
>
> Does your patch remove all the concatenation for all scripts though?
>
> I wanted to note that a side-effect of the concatenation change in 5.5
is that now that `media-editor.js` is being concatenated (looks like it
wasn't in 5.4 by default?), it's causing some issues when using another
concat plugin in conjunction like: https://github.com/Automattic/nginx-
http-concat/
>
> The patch in this ticket does fix our problems though because it removes
things like `media-editor.js` from being concatenated.
>there are ids & widths...possibly by updating the js would work. using
var variablename for concatenation, basically updating code
>
> I'm curious about the reasoning to start concatenating `media-editor.js`
and other scripts like that and if we're seeing other problems like the
one I mentioned.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/50999#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list