[wp-trac] [WordPress Trac] #50882: WP 5.5: Cannot attribute content when deleting users

[WordPress Trac]

#50882: WP 5.5: Cannot attribute content when deleting users
-------------------------------------------------+-------------------------
 Reporter:  webzunft                             |       Owner:  garrett-
                                                 |  eclipse
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.5.1
Component:  Users                                |     Version:  5.5
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing dev-         |     Focuses:
  feedback                                       |  administration
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  needs-patch => has-patch needs-testing dev-feedback
 * owner:  (none) => garrett-eclipse
 * status:  new => assigned


Comment:

 Thanks for the report @webzunft I can confirm @SergeyBiryukov's note on
 this being "Introduced in [48134] / #46872."

 Seems that change didn't get enough testing throughout as there's a few
 other reports.

 Looking into this issue the introduction of the doaction2 param to the
 first request stays along for the ride when the second request to actually
 dodelete occurs as the form on that screen doesn't provide an action so
 inherits all current URL params in it's request.

 To resolve this I've uploaded
 [https://core.trac.wordpress.org/attachment/ticket/50882/46872.diff
 46872.diff] which updates the two forms in the users.php to provide an
 action referring to users.php without any params to avoid this param
 inheritance.

 So far in my testing of the User Bulk Delete process it's working nicely,
 I'll look into the other occurrences to provide a more encompassing fix
 once I've identified all bulk-actions that are being affected. The fix for
 others should be the same just apply the current .php file as it's own
 action without any params.

 CC @SergeyBiryukov / @desrosj / @johnbillion / @whyisjake - Can you test
 and feedback on this approach, I feel this is a candidate for 5.5.1.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50882#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform