[wp-trac] [WordPress Trac] #50343: [PHP 8] Fix deprecation notices for optional function parameters declared before required parameter.

[WordPress Trac]

#50343: [PHP 8] Fix deprecation notices for optional function parameters declared
before required parameter.
-------------------------------------------+-------------------------------
 Reporter:  ayeshrajans                    |       Owner:  SergeyBiryukov
     Type:  enhancement                    |      Status:  closed
 Priority:  normal                         |   Milestone:  5.6
Component:  General                        |     Version:
 Severity:  normal                         |  Resolution:  fixed
 Keywords:  has-patch php8 has-unit-tests  |     Focuses:  coding-standards
-------------------------------------------+-------------------------------
Changes (by SergeyBiryukov):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"48794" 48794]:
 {{{
 #!CommitTicketReference repository="" revision="48794"
 Code Modernization: Fix PHP 8 deprecation notices for optional function
 parameters declared before required parameters.

 As it already was not possible to pass the required parameters without
 also passing the optional one anyway, removing the default value for the
 (not so) optional parameters should not affect backward compatibility.

 This change affects three functions in core:

 * `get_comment_delimited_block_content()`
 * `do_enclose()`
 * `_wp_delete_tax_menu_item()`

 Props jrf, ayeshrajans, desrosj.
 Fixes #50343.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50343#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform