[wp-trac] [WordPress Trac] #38009: #reply-title.comment-reply-title not updating when replying to an individual

WordPress Trac noreply at wordpress.org
Sat Aug 15 11:12:23 UTC 2020


#38009: #reply-title.comment-reply-title not updating when replying to an
individual
------------------------------+----------------------------
 Reporter:  iguel             |       Owner:  isabel_brison
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  5.5
Component:  Comments          |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+----------------------------

Comment (by mailnew2ster):

 The solution would be to change:


 {{{
 var initialHeadingText = ( 'undefined' !== typeof replyElement ) ?
 replyElement.firstChild.textContent : '';
 }}}


 to:

 {{{
 var initialHeadingText = ( null !== replyElement ) ?
 replyElement.firstChild.textContent : '';
 }}}

 or, to be consistent with other similar usage:

 {{{
 var initialHeadingText = replyElement ?
 replyElement.firstChild.textContent : '';
 }}}

 here:

 https://github.com/WordPress/WordPress/commit/b4e1e8f0d144df6337f1b8978c8f3f79023aa88f
 #diff-705579fc6109ea62afe07661843ba138R411

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38009#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list