[wp-trac] [WordPress Trac] #50999: Scripts loaded through concatenation don't print their translations.

WordPress Trac noreply at wordpress.org
Fri Aug 14 17:45:11 UTC 2020


#50999: Scripts loaded through concatenation don't print their translations.
--------------------------+-----------------------------
 Reporter:  herregroen    |       Owner:  SergeyBiryukov
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  5.5.1
Component:  I18N          |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  javascript
--------------------------+-----------------------------

Comment (by mikeyarce):

 Thanks for the report @herregroen !

 Does your patch remove all the concatenation for all scripts though?

 I wanted to note that a side-effect of the concatenation change in 5.5 is
 that now that `media-editor.js` is being concatenated (looks like it
 wasn't in 5.4 by default?), it's causing some issues when using another
 concat plugin in conjunction like: https://github.com/Automattic/nginx-
 http-concat/

 The patch in this ticket does fix our problems though because it removes
 things like `media-editor.js` from being concatenated.

 I'm curious about the reasoning to start concatenating `media-editor.js`
 and other scripts like that and if we're seeing other problems like the
 one I mentioned.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50999#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list