[wp-trac] [WordPress Trac] #50962: WP_HTTP_Response should have protected properties

WordPress Trac noreply at wordpress.org
Wed Aug 12 21:16:05 UTC 2020


#50962: WP_HTTP_Response should have protected properties
--------------------------+------------------------------
 Reporter:  daniel217     |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  REST API      |     Version:  4.4
 Severity:  trivial       |  Resolution:
 Keywords:  close         |     Focuses:  rest-api
--------------------------+------------------------------
Changes (by TimothyBlynJacobs):

 * keywords:   => close
 * focuses:  rest-api, privacy, coding-standards => rest-api
 * component:  HTTP API => REST API
 * version:  5.5 => 4.4


Comment:

 Thanks for the ticket @daniel217 and welcome to trac!

 From my perspective, I agree that it would be better for these to be
 protected properties. But unfortunately I don’t think it would be possible
 to change that at this point without breaking backward compatibility. I’ve
 seen plenty of plugins that do set those properties manually.

 We could change it to protected and implement `__get`, but I don’t think
 we get much benefit at that point.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50962#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list