[wp-trac] [WordPress Trac] #50961: Fix missing ref array in pre_get_users
WordPress Trac
noreply at wordpress.org
Wed Aug 12 20:33:28 UTC 2020
#50961: Fix missing ref array in pre_get_users
--------------------------+-----------------------------
Reporter: andy | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Users | Version: trunk
Severity: normal | Keywords:
Focuses: |
--------------------------+-----------------------------
Code docs in class-wp-user-query.php mark this as passed by reference but
the actual call uses `do_action` instead of `do_action_ref_array`.
{{{
Index: wp-includes/class-wp-user-query.php
===================================================================
--- wp-includes/class-wp-user-query.php (revision 212073)
+++ wp-includes/class-wp-user-query.php (working copy)
@@ -227,7 +227,7 @@
* @param WP_User_Query $this The current WP_User_Query
instance,
* passed by reference.
*/
- do_action( 'pre_get_users', $this );
+ do_action_ref_array( 'pre_get_users', array( &$this ) );
// Ensure that query vars are filled after
'pre_get_users'.
$qv =& $this->query_vars;
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/50961>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list