[wp-trac] [WordPress Trac] #50897: PHP 8: fix final private methods

[WordPress Trac]

#50897: PHP 8: fix final private methods
-------------------------------------------+-------------------------------
 Reporter:  jrf                            |       Owner:  SergeyBiryukov
     Type:  defect (bug)                   |      Status:  closed
 Priority:  normal                         |   Milestone:  5.6
Component:  General                        |     Version:
 Severity:  minor                          |  Resolution:  fixed
 Keywords:  has-patch php8 has-unit-tests  |     Focuses:  coding-standards
-------------------------------------------+-------------------------------
Changes (by SergeyBiryukov):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"48788" 48788]:
 {{{
 #!CommitTicketReference repository="" revision="48788"
 Code Modernization: Remove `final` keyword from private methods.

 Declaring a `private` method as `final` is an oxymoron, as `private`
 methods cannot be overloaded anyway.

 Using `final private function...` will generate a warning in PHP 8.

 Props jrf.
 Fixes #50897.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50897#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform