[wp-trac] [WordPress Trac] #50766: Not enough padding on "Warning: these page should not be the same!"

WordPress Trac noreply at wordpress.org
Tue Aug 11 09:27:59 UTC 2020


#50766: Not enough padding on "Warning: these page should not be the same!"
-------------------------------------------------+-------------------------
 Reporter:  SergeyBiryukov                       |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.6
Component:  Administration                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-screenshots has-  |     Focuses:  ui, css
  patch                                          |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:5 garrett-eclipse]:
 > should the `error` class be replaced by `notice notice-info` instead of
 just adding `notice`?
 > Just asking to see if it should conform to the
 [https://core.trac.wordpress.org/changeset/48145 commit here].

 Yeah, it could be replaced with `notice notice-error` or `notice notice-
 warning`, since this message is a warning, rather than just info, unlike
 the one in [48145].

 That said, it looks like there are still a lot of messages with the legacy
 `error` class in the admin, so that might be something to handle in
 another ticket for all of them.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50766#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list