[wp-trac] [WordPress Trac] #50686: UI issue on nav-menus.php

[WordPress Trac]

#50686: UI issue on nav-menus.php
-------------------------------------+-------------------------------------
 Reporter:  dilipbheda               |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Menus                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  ui, accessibility,
  patch                              |  css, administration
-------------------------------------+-------------------------------------

Comment (by afercia):

 Related: [33109] / #32490 where a `"\f534"` dashicon was added to the
 styling of the invalid input fields. See for example the Add New User
 page. Seems that change missed various input fields in the admin that use
 the same styling. Also, in some pages the icon is completely off place,
 see for example the term.php page in the screenshot below.

 The [https://github.com/WordPress/wordpress-
 develop/blob/5602ba4db7284a4787f0f311008ca9f99a22eab1/src/js/_enqueues/admin/common.js#L153-L170
 validateForm()] function and similar implementations in core that set the
 `form-invalid` CSS class and only add a visual feedback are very old bits
 of code and show their age.

 I'm not sure it is worth spending time to make `validateForm()` more
 accessible. A solid, comprehensive, user input validation API (see #47505)
 would require many more things than a border and some ARIA attributes.
 First of all, it would require a standardized ways to generate the input
 fields, see the [https://make.wordpress.org/core/tag/fields-api/ Fields
 API] project, which is in a dormant state. It should be used for the
 [https://core.trac.wordpress.org/query?status=!closed&keywords=~settings-
 api Settings API] first and then made available to plugins and themes.
 These are big features that historically WordPress misses and would need
 some big effort. Hopefully they will get prioritized, at some point.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50686#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform