[wp-trac] [WordPress Trac] #49236: Use 'comment' instead of '' for the comment_type db field for comments

WordPress Trac noreply at wordpress.org
Fri Aug 7 16:33:54 UTC 2020


#49236: Use 'comment' instead of '' for the comment_type db field for comments
-------------------------------------------------+-------------------------
 Reporter:  imath                                |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  closed
 Priority:  normal                               |   Milestone:  5.5
Component:  Comments                             |     Version:  5.4
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch early commit has-dev-note  |     Focuses:
  dev-reviewed                                   |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"48752" 48752]:
 {{{
 #!CommitTicketReference repository="" revision="48752"
 Comments: Update comment cache in the upgrade routine for changing the
 `comment_type` DB field value in comments table.

 This ensures that comment object cache is cleared after changing the
 comment type to `comment` instead of an empty string.

 Add a unit test for `_wp_batch_update_comment_type()`.

 Follow-up to [47597], [47626], [48225], [48227].

 Props imath, westonruter.
 Reviewed by desrosj, SergeyBiryukov.
 Merges [48748] and [48751] to the 5.5 branch.
 Fixes #49236.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49236#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list