[wp-trac] [WordPress Trac] #49236: Use 'comment' instead of '' for the comment_type db field for comments

[WordPress Trac]

#49236: Use 'comment' instead of '' for the comment_type db field for comments
-------------------------------------------------+-------------------------
 Reporter:  imath                                |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.5
Component:  Comments                             |     Version:  5.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch early commit has-dev-note  |     Focuses:
  dev-reviewed                                   |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-patch early commit has-dev-note dev-feedback => has-patch
     early commit has-dev-note dev-reviewed


Comment:

 Looking at [48748], I'm wondering if we should bump the DB version to
 point to this commit in the upgrade routine. I don't think there is any
 benefit to a site that is running a development version (the upgrade
 routine will "run" again, but nothing will be updated and the caches will
 not clear because no comment IDs will be found), but may be good for
 accuracy.

 Other than that, this looks good to backport. Marking `dev-reviewed`
 pending feedback on my point above.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49236#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform