[wp-trac] [WordPress Trac] #43848: Function "user_can_access_admin_page" refactor.

WordPress Trac noreply at wordpress.org
Fri Aug 7 02:06:31 UTC 2020


#43848: Function "user_can_access_admin_page" refactor.
-------------------------------------------+-----------------------------
 Reporter:  rnaby                          |       Owner:  valentinbora
     Type:  enhancement                    |      Status:  closed
 Priority:  lowest                         |   Milestone:  Future Release
Component:  Administration                 |     Version:
 Severity:  normal                         |  Resolution:  wontfix
 Keywords:  has-patch needs-refresh close  |     Focuses:
-------------------------------------------+-----------------------------
Changes (by khag7):

 * keywords:  has-patch needs-refresh => has-patch needs-refresh close
 * status:  accepted => closed
 * resolution:   => wontfix


Comment:

 I reviewed the proposed patch and compared it against the current
 implementation.

 The proposed patch is mostly whitespace changes and merging of if
 statements.

 For example (pseudo-code):

 {{{
 if( A ){
     something
 }
 if( B ){
     something
 }
 }}}

 to

 {{{
 if( A || B ){
     something
 }
 }}}

 The current implementation is relatively concise and correct with
 WordPress coding standards. There's no need for this ticket to remain
 open.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43848#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list