[wp-trac] [WordPress Trac] #37011: Don’t link custom logo if it’s displayed on the front page

WordPress Trac noreply at wordpress.org
Wed Aug 5 10:57:13 UTC 2020


#37011: Don’t link custom logo if it’s displayed on the front page
------------------------------------+----------------------------
 Reporter:  FlorianBrinkmann        |       Owner:  joedolson
     Type:  enhancement             |      Status:  reopened
 Priority:  highest omg bbq         |   Milestone:  5.5.1
Component:  Themes                  |     Version:  4.6
 Severity:  blocker                 |  Resolution:
 Keywords:  has-patch has-dev-note  |     Focuses:  accessibility
------------------------------------+----------------------------

Comment (by demetris):

 I think we need one more check in order to decide whether to remove the
 link.

 Right now we only check for `is_front_page`. I think we should also check
 if, in addition to that, we are on the first page using `is_paged`.

 That is:

 {{{
 #!php
 if (is_front_page() && !is_paged()) {
    /* Unlink the logo. */
 }
 }}}

 Am I right or am I missing something?

 Cheers!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37011#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list