[wp-trac] [WordPress Trac] #50834: Correct the check whether .htaccess update is required

[WordPress Trac]

#50834: Correct the check whether .htaccess update is required
----------------------------+--------------------
 Reporter:  SergeyBiryukov  |      Owner:  (none)
     Type:  defect (bug)    |     Status:  new
 Priority:  normal          |  Milestone:  5.6
Component:  Permalinks      |    Version:
 Severity:  normal          |   Keywords:
  Focuses:  administration  |
----------------------------+--------------------
 Background: #39547

 [27549] / #19268 introduced a check whether `.htaccess` update is required
 after saving permalink settings, so that "You should update your
 `.htaccess` file now" message is only displayed when necessary.

 As part of the changes in [37747] / #35936 and [38066] / #37380, some
 logic was reshuffled, and the check is now performed before the permalink
 structure is updated, leading to the message not being displayed as
 intended, due to outdated values being compared.

 The check should be performed after the permalink structure update, not
 before.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50834>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform