[wp-trac] [WordPress Trac] #50280: Enable auto-updates shows for plugins with no support

[WordPress Trac]

#50280: Enable auto-updates shows for plugins with no support
-------------------------------------------------+-------------------------
 Reporter:  elrae                                |       Owner:  audrasjb
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.5
Component:  Upgrade/Install                      |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-dev-note commit dev-   |     Focuses:  docs,
  reviewed                                       |  administration
-------------------------------------------------+-------------------------
Changes (by pbiron):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Replying to [comment:55 whyisjake]:
 > In [changeset:"48688" 48688]:
 > {{{
 > #!CommitTicketReference repository="" revision="48688"
 > Upgrade/Install: Only show auto-update for themes that support the
 feature.
 >
 > Similar to the changes for plugins in [48669], let's only show the UI
 for themes when updates are supported for that theme.
 >
 > See #50280.
 > Props dd32.
 > }}}

 The above commit did not include the requisite changes to
 `WP_MS_Themes_List_Table`.  The impact is that in multisite, the
 `Enable/Disable auto-updates` links will still appear for externally
 hosted themes on the `Network Admin > Themes` screen :-(

 I'm looking into what it will take to add the multisite support for this.
 It's complicated by the fact that plugins use an array (returned by
 `get_plugin_data()`) and thus can use `array_merge()` on the info in the
 transient, `array( 'update-supported => true )` and the plugin_data;
 whereas themes use an instance of `WP_Theme`...making the array merge not
 possible.

 I think something can be worked out using the magic `__get()` and
 `__set()` methods of `WP_Theme`...but still looking into that.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50280#comment:66>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform