[wp-trac] [WordPress Trac] #49236: Use 'comment' instead of '' for the comment_type db field for comments

WordPress Trac noreply at wordpress.org
Sun Apr 26 13:12:19 UTC 2020


#49236: Use 'comment' instead of '' for the comment_type db field for comments
-------------------------------------------------+-------------------------
 Reporter:  imath                                |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.5
Component:  Comments                             |     Version:  5.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch early needs-dev-note       |     Focuses:
  commit                                         |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 In [changeset:"47625" 47625]:
 {{{
 #!CommitTicketReference repository="" revision="47625"
 Comments: Restore inclusion of an empty comment type when building the
 `WHERE` clause in `WP_Comment_Query::get_comment_ids()`.

 This ensures that `get_comments( array( 'type' => 'comment' ) )` still
 includes comments that have not yet migrated to the `comment` type.

 Follow-up to [47597].

 Props ocean90.
 See #49236.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49236#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list