[wp-trac] [WordPress Trac] #49852: Use feature image of video attachment as preview instead of icon

[WordPress Trac]

#49852: Use feature image of video attachment as preview instead of icon
-------------------------------------------------+-------------------------
 Reporter:  spacedmonkey                         |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Media                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug needs-refresh has-    |     Focuses:
  patch                                          |
-------------------------------------------------+-------------------------
Changes (by johnbillion):

 * keywords:  needs-patch good-first-bug => good-first-bug needs-refresh
     has-patch


Comment:

 Thanks for the patch @samful and welcome to WordPress Trac!

 Some feedback on your patch, as it's your first one:

 * It looks like the formatting of your patch file isn't right, here's a
 guide for creating a patch file correctly:
 https://make.wordpress.org/core/handbook/tutorials/trac/submitting-a-patch/
 * Not all videos will have a featured image, so we'll need some logic
 which only uses the featured image ID if one exists, and still uses the ID
 of the video attachment if not so the correct icon is displayed.
 * Audio files can actually have a featured image too, although this is not
 a commonly used feature. They're used if you create an audio playlist in
 the classic editor. We might as well add support for featured images for
 audio too.

 Feel free to resubmit your patch using the same file name, and just ask
 here if you have any questions.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49852#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform