[wp-trac] [WordPress Trac] #49236: Use 'comment' instead of '' for the comment_type db field for comments

[WordPress Trac]

#49236: Use 'comment' instead of '' for the comment_type db field for comments
--------------------------------------------+-----------------------------
 Reporter:  imath                           |       Owner:  SergeyBiryukov
     Type:  enhancement                     |      Status:  reopened
 Priority:  normal                          |   Milestone:  5.5
Component:  Comments                        |     Version:  5.4
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch early needs-dev-note  |     Focuses:
--------------------------------------------+-----------------------------

Comment (by imath):

 Thanks for catching these issues @ocean90.

 About the first one, I suggest to add 2 unit tests (see
 [https://core.trac.wordpress.org/attachment/ticket/49236/49236.3.ut.patch
 49236.3.ut.patch]), 1 for `wp_handle_comment_submission()` and the other
 one for `wp_insert_comment()`

 I agree we should commit your patch.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49236#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform