[wp-trac] [WordPress Trac] #49610: Twenty Twenty: Block editor inserter is missing the '+'
WordPress Trac
noreply at wordpress.org
Sat Apr 18 09:14:37 UTC 2020
#49610: Twenty Twenty: Block editor inserter is missing the '+'
-------------------------------------+---------------------
Reporter: nrqsnchz | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.5
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: needs-testing has-patch | Focuses: css
-------------------------------------+---------------------
Comment (by aristath):
This is a twofold issue...
The 1st issue: 2020 adds the `color:inherit` which should be removed, so
the patch from https://core.trac.wordpress.org/ticket/49610#comment:5
needs to be applied.
The 2nd issue: The theme properly adds `add_theme_support( 'dark-editor-
style' );` when a dark background-color is used as documented on
https://developer.wordpress.org/block-editor/developers/themes/theme-
support/#dark-backgrounds, BUT it never adds support for `editor-styles`,
so the `dark-editor-style` support is not applied.
In the beginning of the `twentytwenty_block_editor_settings` function this
line should be added:
`add_theme_support( 'editor-styles' );`
If both changes are applied then everything works fine both for light &
dark backgrounds.
I'm sorry for not creating a patch, call it an a11y thing if you want. The
cognitive load to use SVN is far greater than that of git and I just can't
do it right now.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/49610#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list