[wp-trac] [WordPress Trac] #49916: Add id attributes to the plugin activate/deactivate buttons

WordPress Trac noreply at wordpress.org
Thu Apr 16 17:04:31 UTC 2020


#49916: Add id attributes to the plugin activate/deactivate buttons
--------------------------------------+-----------------------------
 Reporter:  shooper                   |       Owner:  SergeyBiryukov
     Type:  enhancement               |      Status:  closed
 Priority:  normal                    |   Milestone:  5.5
Component:  Plugins                   |     Version:
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  good-first-bug has-patch needs-refresh => good-first-bug has-
     patch


Comment:

 Replying to [comment:3 mukesh27]:
 > I tested the patch
 [https://core.trac.wordpress.org/attachment/ticket/49916/49916.diff
 49916.diff] and found one bug.
 >
 > {{{#!php
 > <a href="%s" aria-label="%s" id-"deactivate-%s">%s</a>
 > }}}

 Thanks for testing! Just noting this is already corrected in [47588].

 Sorry for missing props, haven't refreshed the tab before committing :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49916#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list