[wp-trac] [WordPress Trac] #49893: TwentyTwenty: TikTok and ResearchGate Social Icons
WordPress Trac
noreply at wordpress.org
Mon Apr 13 19:39:51 UTC 2020
#49893: TwentyTwenty: TikTok and ResearchGate Social Icons
----------------------------------------------+-----------------------
Reporter: mislavjuric | Owner: audrasjb
Type: enhancement | Status: accepted
Priority: normal | Milestone: 5.5
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots commit | Focuses:
----------------------------------------------+-----------------------
Changes (by audrasjb):
* milestone: Awaiting Review => 5.5
Comment:
Replying to [comment:4 mislavjuric]:
> 1) How can I help out? I am not a graphic designer, but maybe I can look
for ResearchGate SVG on the Internet. I am not sure if I will be able to
find one that requires no attribution.
As per previous comments, we should probably first include ResearchGate as
an Embed provider so it will need another ticket. We already did that for
TikTok in WP 5.3/5.4. For reference, see ticket #49083. I think
ResearchGate should follow the same path.
> 2) How do I apply the Tik-Tok icon you linked? Do I have to manually
edit the files on my server as signified in the diff file? Is there a way
to automatically do so?
This diff file needs to be applied to trunk using Git or SVN versioning
system. I think it can be implemented in WordPress 5.5, planned for
August.
But if you want to implement this patch on your website, I shared above
the fixed PHP file. It's located in `wp-content/twentytwenty/classes` You
can replace the existing file with this one if you want.
Cheers,
Jb
--
Ticket URL: <https://core.trac.wordpress.org/ticket/49893#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list