[wp-trac] [WordPress Trac] #47303: Consider removing extra trailing spaces from links with the `dashicons-external` icon

[WordPress Trac]

#47303: Consider removing extra trailing spaces from links with the `dashicons-
external` icon
-------------------------------------------------+-------------------------
 Reporter:  SergeyBiryukov                       |       Owner:
                                                 |  isabel_brison
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  I18N                                 |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-screenshots has-  |     Focuses:
  patch needs-testing needs-refresh              |
-------------------------------------------------+-------------------------
Changes (by mukesh27):

 * keywords:  good-first-bug has-screenshots has-patch needs-testing =>
     good-first-bug has-screenshots has-patch needs-testing needs-refresh


Comment:

 Hi there!

 The patch needs an update so can @isabel_brison you please update it?

 On small suggestion from my end.

 Use -1px top margin instead of -2px.

 {{{#!php
 .screen-reader-text + .dashicons-external {
    margin-top: -1px;
    margin-left: 4px;
 }
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47303#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform