[wp-trac] [WordPress Trac] #49824: Site Health instantiation prevents use of some hooks by plugins.

WordPress Trac noreply at wordpress.org
Fri Apr 10 08:46:14 UTC 2020


#49824: Site Health instantiation prevents use of some hooks by plugins.
---------------------------+------------------------
 Reporter:  peterwilsoncc  |       Owner:  whyisjake
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:  5.4.1
Component:  Site Health    |     Version:  5.4
 Severity:  normal         |  Resolution:  fixed
 Keywords:  commit         |     Focuses:
---------------------------+------------------------

Comment (by SergeyBiryukov):

 Just noting the commit looks good to me too.

 > Site Health instantiation prevents use of some hooks by plugins.
 >
 > As the WP_Site_Health class is instantiated prior to plugins being
 required and the `plugins_loaded` hook being fired, it prevents plugins
 from using the following hooks in the functions called by
 `maybe_create_scheduled_event()`.

 In the future though, I think it would be better if the commit message
 highlighted the solution and the changes made, rather than just the
 problem. The [https://make.wordpress.org/core/handbook/best-practices
 /commit-messages/ Commit Messages] handbook article might be helpful.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49824#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list