[wp-trac] [WordPress Trac] #49861: Emoji javascript comment

WordPress Trac noreply at wordpress.org
Fri Apr 10 01:52:42 UTC 2020


#49861: Emoji javascript comment
------------------------------+-------------------------
 Reporter:  superpoincare     |       Owner:  (none)
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  5.5
Component:  Build/Test Tools  |     Version:  5.4
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:  javascript
------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * component:  General => Build/Test Tools
 * milestone:  Awaiting Review => 5.5


Comment:

 Thanks for the ticket!

 Introduced in [46589] / #48424.

 It seems like we could either:
 * Remove the banner from `wp-emoji-release.min.js`.
 * Or (preferably) use [https://www.npmjs.com/package/grunt-include-replace
 grunt-include-replace] instead of [https://www.npmjs.com/package/grunt-
 includes grunt-includes] for including the file, since it doesn't look
 like the latter can remove something from the file contents before
 including.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49861#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list