[wp-trac] [WordPress Trac] #49863: Twenty Nineteen: Button block editor styles need a refresh
WordPress Trac
noreply at wordpress.org
Thu Apr 9 18:38:04 UTC 2020
#49863: Twenty Nineteen: Button block editor styles need a refresh
---------------------------+-------------------------
Reporter: kjellr | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.5
Component: Bundled Theme | Version:
Severity: normal | Keywords: needs-patch
Focuses: |
---------------------------+-------------------------
Post WordPress 5.4, the Gutenberg plugin now syncs up the button markup in
the editor with what's rendered on the front end:
https://github.com/WordPress/gutenberg/pull/21266#issuecomment-611344160
Old button markup:
{{{
<!-- wp:button -->
<div class="wp-block-button"><a class="wp-block-button__link">My
button</a></div>
<!-- /wp:button -->
}}}
New button markup:
{{{
<!-- wp:button -->
<a class="wp-block-button wp-block-button__link">My button</a>
<!-- /wp:button -->
}}}
----
Twenty Nineteen's editor styles for the button block currently target the
`.wp-block-button__link` selector as a child of the `wp-block-button`
separator, but that's no longer the case. As a result, these button editor
styles aren't getting picked up when using the Gutenberg plugin.
This should be corrected. In order to provide compatibility with earlier
Gutenberg versions, changes here should probably end up preserving the old
selectors too.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/49863>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list