[wp-trac] [WordPress Trac] #37011: Don’t link custom logo if it’s displayed on the front page

[WordPress Trac]

#37011: Don’t link custom logo if it’s displayed on the front page
-------------------------------------------------+-------------------------
 Reporter:  FlorianBrinkmann                     |       Owner:  joedolson
     Type:  enhancement                          |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.5
Component:  Themes                               |     Version:  4.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-dev-   |     Focuses:
  note                                           |  accessibility
-------------------------------------------------+-------------------------
Changes (by sabernhardt):

 * keywords:  has-patch => has-patch needs-testing needs-dev-note


Comment:

 Related: #31027 began work toward removing the home page logo link in the
 Twenty Fifteen theme.

 For the latest patch:

 1. The image needs a "custom-logo-link" container element so it can match
 the theme's styles of the linked logo on other pages. This patch keeps the
 same styling in at least Twenty Seventeen and Twenty Nineteen; logos in
 Twenty Fifteen and Twenty Twenty appear to be the same with or without the
 container element. Some of the
 [https://wpdirectory.net/search/01E5FRS83YQ6D5WXJA0ZH24GG8 themes that
 target the `a` element] should still need updating for this change.
 2. The conditional logic is revised to keep the link on the blog page when
 using a static front page.
 3. The function description and `since` note are updated, and I'm sure
 they could be improved further.

 It would be good to test in multisite, as well as more themes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37011#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform